Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bot): merge.block_on_neutral_required_check_runs #785

Merged
merged 5 commits into from
Feb 4, 2022

Conversation

chdsbd
Copy link
Owner

@chdsbd chdsbd commented Feb 4, 2022

When merge.block_on_neutral_required_check_runs is enabled, we won't merge the pull request if a required check run has a neutral conclusion.

related: #780

When `merge.block_on_neutral_required_check_runs` is enabled, we won't merge the pull request if a required check run has a neutral conclusion.
@chdsbd chdsbd requested a review from sbdchd February 4, 2022 01:50
@@ -932,7 +947,7 @@ async def set_status(msg: str, markdown_content: Optional[str] = None) -> None:
"continuous-integration/travis-ci/pr" in passing
or "continuous-integration/travis-ci/push" in passing
):
required.remove("continuous-integration/travis-ci")
required_status_checks.remove("continuous-integration/travis-ci")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutation! 😱

@chdsbd chdsbd added the automerge Mark PR for auto merge by Kodiak label Feb 4, 2022
@kodiakhq kodiakhq bot merged commit 866b9f1 into master Feb 4, 2022
@kodiakhq kodiakhq bot deleted the chris/block_on_neutral_required_check_runs branch February 4, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Mark PR for auto merge by Kodiak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants