ref(bot): use reviewDecision instead of custom calculation #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can use reviewDecision to hopefully provide a more consistent view of reviews for a pull request.
sbdchd
approved these changes
Nov 25, 2021
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 25, 2021
Remove some old code that is unnecessary as of #762
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 26, 2021
This is enum is unused now since #762.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use reviewDecision to hopefully provide a more consistent view of reviews for a pull request.
My theory for some of the issues in #761 is that the GitHub API is being inconsistent when called via the v3 API vs the GraphQL API. Using only reviewDecision will help us avoid depending on the v3 API.
I've deployed this change