Fix for #52, #53, and #55 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the core data model has changed, we need a way to transform the SDMX document from the previous model to the new model for the backward compatibility. This commit adds `to_sdmx` method to `DataModelSerializers` class so that a preprocessor for the SDMX transform can be added per model basis.
…rializers` class The variable `unbound_func` in the lambda function of `attach_to_data_model` method of `DataModelSerializers` class took the value from the surrounding scope. This made every overwritten serializer bound to the last value of `unbound_func`. This commit fixes this problem.
p2
added a commit
that referenced
this pull request
Sep 19, 2014
I cannot test this but the code looks good, so I'll finally merge it into develop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #52 by increasing the length of
translation_fidelityfrom 50 to 200, fixes #53 by simply removing a valid SDMJ document from the the set of invalid SDMJ documents, and fixed #55 by using a function factory. This also adds a preprocessor hook for the SDMX transform.