Add HPA targeted at Rollout #315
Merged
+53
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanayo04
commented
Jun 13, 2024
| @@ -13,7 +13,7 @@ metadata: | |||
| {{- end }} | |||
| name: "{{ include "akka.fullname" . }}" | |||
| spec: | |||
| {{- if and (not .Values.autoscaling.enabled) .Values.replicaCount }} | |||
| {{- if and (not .Values.autoscaling.enabled) (ne .Values.replicaCount nil) }} | |||
There was a problem hiding this comment.
Change .Values.replicaCount to ne .Values.replicaCount nil because we want to allow a setting of 0, even though it currently becomes true when .Values.replicaCount is not nil or 0.
cw-sakamoto
reviewed
Jun 13, 2024
| name: "{{ template "akka.fullname" . }}" | ||
| {{- end }} | ||
|
|
||
| {{- if .Values.autoscalingRollout.enabled -}} |
There was a problem hiding this comment.
Do we define autoscaling and autoscalingRollout together? If they are defined together, then --- is necessary to separate yaml, and if they are not defined together, then it would be better to add them to the condition as https://github.com/chatwork/charts/blob/master/fluentd/templates/statefulset.yaml#L2.
cw-sakamoto
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist