Fix S3 metrics test to actually test the correct code path #6
+120
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
force-pushed
the
fix-s3-metrics-test
branch
from
3ebe8b6 to
c2f0bca
Compare
mumoshu
force-pushed
the
fix-s3-metrics-test
branch
from
c2f0bca to
8076a44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3 introduced localstack for testing S3 metrics.
But we have never created a fake S3 bucket or object necessary for successful metrics to be obtained.
This PR updates the test to do create fake S3 bucket and object, along with parsing metrics exposed by aws-checker, so that you can verify that "s3 ok metrics" is present.