Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use min permissions for test workflow #58

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

mumoshu
Copy link
Contributor

@mumoshu mumoshu commented Dec 3, 2024

This removes unnecessary permissions like packages:read and metadata:read from the test workflow, just to make it more secure.

https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

Copy link
Contributor

@cw-atkhry cw-atkhry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cw-atkhry cw-atkhry merged commit aa1479c into chatwork:main Dec 3, 2024
5 checks passed
@mumoshu mumoshu deleted the min-perm-for-test branch December 4, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants