Support custom global.imageRegistry in migration job #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a common standard to prefix dockerhub images with global.imageRegistry variable in case someone does not want/can not use dockerhub. Example: elastic/helm-charts#720 All dependent charts (postgres/redis) support this variable, chatwoot has an option as well, but busybox image is hardcoded for dockerhub. This change allows to use global.imageRegistry here as well
vishnu-narayanan
requested changes
Jan 20, 2025
There was a problem hiding this comment.
@gugu Thank you for the PR. Could you please address the minor review comments?
Also, please add the defaults in values.yaml file.
global:
imageRegistry: ""
| @@ -39,7 +39,7 @@ spec: | |||
| done; | |||
| echo "Database ready to accept connections." ; | |||
| - name: init-redis | |||
| image: busybox:1.28 | |||
| image: "{{.Values.global.imageRegistry}}busybox:1.28" | |||
There was a problem hiding this comment.
Suggested change
| image: "{{.Values.global.imageRegistry}}busybox:1.28" | |
| image: "{{ .Values.global.imageRegistry | default "" }}busybox:1.28" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a common standard to prefix dockerhub images with global.imageRegistry variable in case someone does not want/can not use dockerhub. Example: elastic/helm-charts#720
All dependent charts (postgres/redis) support this variable, chatwoot has an option as well, but busybox image is hardcoded for dockerhub. This change allows to use global.imageRegistry here as well