Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update capi release script after integration test refactor #1576

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Update capi release script after integration test refactor #1576

merged 1 commit into from
Sep 11, 2024

Conversation

maci3jka
Copy link
Contributor

@maci3jka maci3jka commented Sep 4, 2024

Removed unnecessary steps after integration tests refactor

KU-1226

Mark below if this PR requires a job refresh (jjb) after merge:

  • Needs jjb after merge

Please make sure to open PR's against the correct code:

  • For integration tests, please make changes in jobs/integration
  • For validation envs, jobs/validate
  • For MicroK8s,jobs/microk8s
  • For charm/bundle builds, jobs/build-charms

Update capi release script
6f55885 
Removed unnecessary steps after integration tests refactor
KU-1226
@maci3jka
Copy link
Contributor Author

maci3jka commented Sep 4, 2024

merge after canonical/cluster-api-bootstrap-provider-microk8s#113

kwmonroe
kwmonroe approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maci3jka, nice work simplifying this job. For future travelers, these steps are now baked into the cluster and cluster-inplace manifests.

No job yamls were hurt in this PR, no jjb needed.

LGTM.

@kwmonroe kwmonroe merged commit b226daa into charmed-kubernetes:main Sep 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwmonroe kwmonroe kwmonroe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maci3jka @kwmonroe