Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go 1.21 for the 1.29 builds #1449

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Use Go 1.21 for the 1.29 builds #1449

merged 1 commit into from
Nov 9, 2023

Conversation

neoaggelos
Copy link
Contributor

Summary

Use Go 1.21 for building Kubernetes 1.29

Fixes https://launchpadlibrarian.net/696845175/buildlog_snap_ubuntu_focal_arm64_kubelet-1.29_BUILDING.txt.gz

Detected go version: go version go1.20.11 linux/arm64.
Kubernetes requires go1.21 or greater.
Please install go1.21 or later.

Cynerva
Cynerva approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@Cynerva Cynerva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Cynerva Cynerva merged commit 0fb5c8a into main Nov 9, 2023
6 checks passed
@Cynerva Cynerva deleted the fix/build-1.29 branch November 9, 2023 20:02
@Cynerva
Copy link
Contributor

Cynerva commented Nov 9, 2023

I deleted the v1.29.0-alpha.3 branches from the snap-* repos, then ran the sync-snaps job to regenerate them. We should start to see some builds go through with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cynerva Cynerva Cynerva approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neoaggelos @Cynerva