Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LP#1940328] Add loadbalancer relation named lb-consumers #5

Merged
merged 7 commits into from
Jan 24, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Jan 16, 2024

LP#1940328

It's a long time coming, but we're finally going to address this bug by adding the lb-consumer to this charm, updating it to support both the old loadbalancer:public-http relation as the current lb-consumers:loadbalancer relation.

By supporting both -- the 1.28/stable charms can relate to this updated charm, then migrate to the lb-consumers relatoin

@addyess addyess force-pushed the lp1940328/relation-lp-consumers branch from 29a1856 to cdd1460 Compare January 17, 2024 14:15
@addyess addyess force-pushed the lp1940328/relation-lp-consumers branch from cdd1460 to 7bd1359 Compare January 17, 2024 16:48
@addyess addyess changed the title Replace loadbalancer relation with lb-consumers relation [LP#1940328] Add loadbalancer relation named lb-consumers Jan 17, 2024
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nit. LGTM!

reactive/openstack.py Outdated Show resolved Hide resolved
@mateoflorido mateoflorido merged commit 1e47aa3 into main Jan 24, 2024
6 checks passed
@mateoflorido mateoflorido deleted the lp1940328/relation-lp-consumers branch January 24, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants