Prevent automatic snap upgrades #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 3, 2023
addyess
reviewed
Nov 3, 2023
Comment on lines
+621
to
+627
| for snap in BASIC_SNAPS: | ||
| install_snap( | ||
| snap, | ||
| channel=channel, | ||
| classic=True, | ||
| ignore_running=snap == "kubectl", | ||
| ) |
Comment on lines
+630
to
+631
| for snap in CONTROL_PLANE_SNAPS: | ||
| install_snap(snap, channel=channel) |
addyess
reviewed
Nov 3, 2023
Co-authored-by: Adam Dyess <[email protected]>
Co-authored-by: Adam Dyess <[email protected]>
addyess
reviewed
Jan 3, 2024
Comment on lines
+614
to
+616
| status.add( | ||
| BlockedStatus("Snap channel version has changed. An upgrade is required.") | ||
| ) |
There was a problem hiding this comment.
@mateoflorido do you see any trouble changing this text to match the previous message in reactive:
Needs manual upgrade, run the upgrade action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements a mechanism to prevent automatic upgrades.
Changes
channelparameter is changed.BlockedStatusif thechannelparameter has changed and an upgrade is required.