Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve upgrade-snaps action to better recover in error cases #27

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Aug 17, 2024

Overview

Addresses LP#2077189
Running outside of a reconcile loop, the action will need to handle errors raised from the install method as ReconcilerErrors.

Details

Copy link

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, special thanks for considering the reconcile error that may be driven by multiple underlying problems. LGTM.

@addyess addyess merged commit fad2dee into main Aug 19, 2024
6 checks passed
@addyess addyess deleted the bugs/lp2077189/upgrade-action-isnt-reconciled branch August 19, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants