[LP#2047967] Require the upgrade-action when changing the snap channel #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoflorido
previously approved these changes
Jan 3, 2024
mateoflorido
reviewed
Jan 4, 2024
addyess
force-pushed
the
bug/lp2047967/require-snap-upgrade-on-channel-change
branch
from
fa70e87
to
e4af958
Compare
mateoflorido
approved these changes
Jan 4, 2024
addyess
deleted the
bug/lp2047967/require-snap-upgrade-on-channel-change
branch
addyess
added a commit
that referenced
this pull request
Jan 4, 2024
#11) * Require the upgrade-action when changing the snap channel * parse snap info as yaml * remove unnecessary bytes decode * handle situation where snap is missing channels info * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP#2047967
In an effort to require an upgrade action when the snap channel changes to something different from the currently running snaps, notify the user of a necessary change.
As a drive-by -- prevent users from selecting a snap channel that doesn't exist for any of the required snaps
New features
channelconfig to a different channel causes the charm to test each snap for a revision in the specified channelmaj.minversions will change -- if so it blocks for an upgradeupgradeaction to runPossible issues:
switch from
maj.min/edgetomaj.min/stablecould result in a downgrade without a charm upgrade actionmaj.minare the same, so the charm doesn't block waiting on a charm action. Perhaps this is okay since they are within the same channel??