Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin cdk-addons to the charm's channel and warn about cdk-addons deprecations #358

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Jun 25, 2024

Addresses Issues

LP#2070379

Overview

Actively retire certain addons from cdk-addons by providing charm blocked state warnings for situations where users are using those features.

Details

  • pinning the cdk-addons snap based on the charm's release channel. This will be determined from the charm branch the charm is built from (not the actual charmhub channel since that's not possible). The risk (edge,candidate,beta,stable) will match the configured snap channel.

example) So juju config kcp channel=1.28/beta sets the snap channel. If charm is built from the release_1.30 branch, then cdk-addons 1.30/beta will be installed along side the charm.

  • Readds the openstack relation is added back in purely so the user can upgrade and see a blocked message
  • Readds the config option enable-nvidia-plugin whose only acceptable value is "false" in order to dismiss blocked message

Associated PRs:

Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

plugin: nil
source: ./
override-prime: |
git -C $CRAFT_PART_SRC branch --show-current >> $CRAFT_PRIME/templates/charm_branch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever!

@kwmonroe kwmonroe merged commit 0e97bce into main Jul 1, 2024
7 checks passed
@kwmonroe kwmonroe deleted the KU_1044/warn-about-cdk-addons-deprecations branch July 1, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants