Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Install jq from deb to support arm64 #78

Closed

Conversation

ghislainbourgeois
Copy link

This changes the action to install jq from the apt repository instead of a snap, to enable the action to work on arm64.

The action currently installs jq from a specific snap revision that only exists for amd64. There is a jq deb in main; it is supported on more architectures and is more up to date.

The snap also exists for arm64, but we would have to track the latest/stable track. This could change more often than the deb package, which is why I propose this change with the deb instead.

@addyess
Copy link
Member

addyess commented May 15, 2024

@ghislainbourgeois I came here to do exactly the same thing and found you'd already done it. We need to build the js though and commit into the repo. See the contributors guide

@addyess
Copy link
Member

addyess commented May 15, 2024

Let's get this done ASAP!

@ghislainbourgeois
Copy link
Author

@addyess I just pushed the commit. I had to use the environment variable that I found in #55 for things to build however.

@addyess
Copy link
Member

addyess commented May 15, 2024

@addyess I just pushed the commit. I had to use the environment variable that I found in #55 for things to build however.

💯 That's the one

@addyess
Copy link
Member

addyess commented May 15, 2024

@addyess I just pushed the commit. I had to use the environment variable that I found in #55 for things to build however.

💯 That's the one

@ghislainbourgeois

Okay yeah... Lemme look at this in the morning. Juju-bundle and juju-crashdump are gonna complain too. They are pinned to the amd64 versions too for security bc using a channel can present a security issue

@addyess
Copy link
Member

addyess commented May 16, 2024

closing in favor of #79

@addyess addyess closed this May 16, 2024
@ghislainbourgeois ghislainbourgeois deleted the fix-arm64 branch May 16, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants