Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape RebootProgram with quotes when marshalling #33

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

NucciTheBoss
Copy link
Member

Small PR that fixes #32. Also renames ReasonCallback to QuoteCallback since the name ReasonCallback is too scoped to the Reason configuration key that several Slurm configuration objects support.

Bumps slurmutils to version 0.8.3.

Change assigned callback from generic `Callback` to `QuoteCallback`.

Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Copy link
Contributor

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NucciTheBoss NucciTheBoss merged commit 5d944b4 into charmed-hpc:main Nov 13, 2024
3 checks passed
@NucciTheBoss NucciTheBoss deleted the fix-gh32 branch December 9, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: slurm.conf editor doesn't correctly handle RebootProgram option
2 participants