This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
feat!: overhaul slurmrestd charm API #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbeedy
force-pushed
the
slurm_config_editor_preparation
branch
from
b843a55 to
f414f01
Compare
NucciTheBoss
suggested changes
Jun 19, 2024
|
Hey @jamesbeedy 👋 Similar to the slurmd operator, could you please apply the changes you made to the slurmdbd and slurmctld operators here as well before merging? We can focus on feature refinement in follow-on pull requests 😄 |
jamesbeedy
force-pushed
the
slurm_config_editor_preparation
branch
from
14237a7 to
0367e5f
Compare
Changes include: * remove jinja2 and replace with `Path().write_text()` * remove `slurm-ops-manager` 3rd party dep and replace with local `slurmrestd_ops.py` * consolidate the yaml files into a single `charmcraft.yaml` * rename interface slurmrestd -> slurmctld * cleanup from PR review * remove unused code * addeded logging * simplified api * reduced code footprint * consolidated yaml files into charmcraft.yaml * added type checking
|
@NucciTheBoss g2g on my end |
jamesbeedy
force-pushed
the
slurm_config_editor_preparation
branch
from
1b1f0a6 to
0367e5f
Compare
NucciTheBoss
approved these changes
Jun 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please reference the Slurm Charms Change Summary Document for an in-depth explanation of these changes.
Changes include:
Path().write_text()slurm-ops-manager3rd party dep and replace with localslurmrestd_ops.pycharmcraft.yaml