Skip to content
This repository has been archived by the owner on Aug 9, 2024. It is now read-only.

chore: enable CI for the experimental branch #41

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ name: slurmd charm tests
on:
workflow_call:
pull_request:
branches:
- main

jobs:
inclusive-naming-check:
Expand Down
101 changes: 101 additions & 0 deletions .github/workflows/experimental.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
# Copyright 2023 Canonical Ltd.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

name: slurmd charm tests (experimental)
on:
workflow_call:
pull_request:
branches:
- experimental

jobs:
inclusive-naming-check:
name: Inclusive naming check
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: woke
uses: get-woke/woke-action@v0
with:
# Cause the check to fail on any broke rules
fail-on-error: true

lint:
name: Lint
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Install dependencies
run: python3 -m pip install tox
- name: Run linters
run: tox -e lint

type:
name: Type check with pyright
runs-on: ubuntu-22.04
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Install dependencies
run: python3 -m pip install tox
- name: Run pyright
run: tox -e type

unit-test:
name: Unit tests
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Install dependencies
run: python3 -m pip install tox
- name: Run tests
run: tox -e unit

integration-test:
strategy:
fail-fast: true
matrix:
bases:
- [email protected]
name: Integration tests (LXD) | ${{ matrix.bases }}
runs-on: ubuntu-latest
needs:
- inclusive-naming-check
- lint
- type
- unit-test
steps:
- name: Checkout
uses: actions/checkout@v4
with:
path: main
- name: Fetch slurmctld
uses: actions/checkout@v4
with:
repository: charmed-hpc/slurmctld-operator
path: slurmctld-operator
ref: experimental
- name: Setup operator environment
uses: charmed-kubernetes/actions-operator@main
with:
provider: lxd
juju-channel: 3.1/stable
- name: Run tests
run: |
cd main && tox run -e integration -- \
--charm-base=${{ matrix.bases }} \
--use-local
4 changes: 2 additions & 2 deletions tests/integration/test_charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ async def test_munge_is_active(ops_test: OpsTest):
"""Test that munge is active."""
logger.info("Checking that munge is active inside Juju unit")
slurmd_unit = ops_test.model.units.get(UNIT_NAME)
cmd_res = (await slurmd_unit.ssh(command="systemctl is-active munge")).strip("\n")
cmd_res = (await slurmd_unit.ssh(command="systemctl is-active snap.slurm.munged")).strip("\n")
assert cmd_res == "active"


Expand All @@ -81,5 +81,5 @@ async def test_slurmd_is_active(ops_test: OpsTest):
"""Test that slurmd is active."""
logger.info("Checking that slurmd is active inside Juju unit")
slurmd_unit = ops_test.model.units.get(UNIT_NAME)
cmd_res = (await slurmd_unit.ssh(command="systemctl is-active slurmd")).strip("\n")
cmd_res = (await slurmd_unit.ssh(command="systemctl is-active snap.slurm.slurmd")).strip("\n")
assert cmd_res == "active"