This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
test: fix unit tests & pull CI changes #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to add the part `charm: {}` to make the charm pack correctly.
jedel1043 and I found that this part declaration must be included in
`charmcraft.yaml`, or it will fail to pack the charm correctly.
nhc will be there, but the charm won't :'(
Signed-off-by: Jason C. Nucciarone <[email protected]>
Previously, if tar failed to extract the contents of the nhc tarball to `/tmp/nhc`, _install_nhc_from_tarball would throw an unhandled excepting that would cause the charm to bork. Now we catch if tar fails to extract the contents of the tarball, log the error output for the asministrator to read, and return False so that the slurmd operator can properly handle and install failure. Signed-off-by: Jason C. Nucciarone <[email protected]>
This will always pull from `main` when testing against `slurmctld-operator`, which is arguably better when trying to do breaking changes in integrations between the charms.
This fixes the CI release job, because 2.5.0 added support for the unified charmcraft.yaml file.
…ll-ci-fixes Pulls the latest CI changes to be able to correctly test our patches.
jedel1043
force-pushed
the
fix-unit-tests-experimental
branch
from
f9531b4 to
fb1222c
Compare
jedel1043
changed the title
NucciTheBoss
approved these changes
Jul 19, 2024
|
Integration tests will fail because the Slurm version in main is incompatible with the Slurm version in experimental. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the unit tests that were failing thanks to #35.
Updates
slurm_opsto the latest version.Merges from the main branch to use the new CI.
How was the code tested?
Locally on my Ubuntu Jammy development environment
Checklist