feat: add the _daemon_ user for non-privileged services
#44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
force-pushed
the
daemon-user
branch
2 times, most recently
from
277fdf3 to
b3b15e2
Compare
NucciTheBoss
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Great as this partially addresses #40 🤩
Just two minor suggestions, but other than that I think this is good for unblocking COS on the experimental branch.
[Side note]: The reason this partially addresses issue 40 is because we still need to create users for the other Slurm daemons since it's also encouraged to not run them as root but instead a dedicated SlurmUser. Ideally we can use _daemon_ for them, but we'll still need to create a separate user for slurmrestd since slurmrestd can run as neither root or SlurmUser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows running
slurmrestdusing the unprivileged user_daemon_.