Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make the tox fetch-lib command work #7

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: make the tox fetch-lib command work #7

merged 1 commit into from
Aug 7, 2024

Conversation

jedel1043
Copy link
Collaborator

Apparently fetch-lib needs at least the charmcraft.yaml file to work.

@jedel1043 jedel1043 requested a review from NucciTheBoss August 7, 2024 00:00
NucciTheBoss
NucciTheBoss approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One could wonder if we could just assemble this file on the fly when we invoke the fetch-lib action and then clean it up after we're done. Probably more trouble than it's worth however 😅

@NucciTheBoss NucciTheBoss merged commit b6fe7e6 into charmed-hpc:main Aug 7, 2024
5 checks passed
@jedel1043 jedel1043 deleted the fetch-lib-fix branch August 7, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NucciTheBoss NucciTheBoss NucciTheBoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedel1043 @NucciTheBoss