Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): initialize lxd before packing charm #47

Conversation

NucciTheBoss
Copy link
Member

The upload-charm action does not initialize LXD which will cause the worklflow to fail if destructive-mode is set to false.

This PR is a follow-on fix for #42 since the upload-charm action doesn't set up LXD itself.

The `upload-charm` action does not initialize LXD which will cause
the worklflow to fail if destructive-mode is set to false.

Signed-off-by: Jason C. Nucciarone <[email protected]>
Copy link
Collaborator

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Hopefully this is enough to fix CI

@NucciTheBoss NucciTheBoss merged commit 60eae44 into charmed-hpc:main Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release workflow is busted due to Ubuntu version mismatch
2 participants