chore(slurmctld): use peer relation for ingress ip #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes remove the unused "cluster_name" from the relation data sent to slurmd on the slurmd relation. Additionally, make the "cluster_name" property private.
These changes add a peer relation for the slurmctld charm and replace using the slurmd interface to obtain the ingress_address with the new slurmctld-peer relation. The reason for this change is that we do not want to depend on the existence of the slurmd relation in order to know our ip. Using a peer relation we will always have resolvability so long as juju knows the ip address of the unit.
NucciTheBoss
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a peer relation for the slurmctld charm and
replace using the slurmd interface to obtain the ingress_address
with the new slurmctld-peer relation.
The reason for this change is that we do not want to depend on
the existence of the slurmd relation in order to know our ip.
Using a peer relation we will always have resolvability so long as
juju knows the ip address of the unit.