Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable CI actions #4

Merged
merged 2 commits into from
Aug 6, 2024
Merged

ci: enable CI actions #4

merged 2 commits into from
Aug 6, 2024

Conversation

jedel1043
Copy link
Collaborator

This adds another command in tox to generate a Charmhub token, which should be useful to regenerate it in an easier way.

@jedel1043 jedel1043 requested a review from NucciTheBoss August 6, 2024 18:48
@jedel1043
Copy link
Collaborator Author

Looking good so far. Let's see if integration tests work.

NucciTheBoss
NucciTheBoss requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generating the token will be super helpful. Don't need to clunk our way around the CLI.

Just some comments, but overall I think this PR looks good!

charms/slurmctld/charmcraft.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
repository.py Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@NucciTheBoss
Copy link
Member

Hmm... might need to run the integration tests locally to get a better idea of what the issues. Seems like slurmctld is failing to reach an active state which indicates that something is going wrong with the setup process.

@jedel1043 jedel1043 marked this pull request as draft August 6, 2024 20:08
@jedel1043
ci: enable CI actions
a92143a 
This adds another command in tox to generate a Charmhub token, which should be useful to regenerate it in an easier way.
@jedel1043 jedel1043 marked this pull request as ready for review August 6, 2024 21:08
@jedel1043 jedel1043 requested a review from NucciTheBoss August 6, 2024 21:08
NucciTheBoss
NucciTheBoss approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Really tiny change needed in ci.yaml, but I can commit the fix as a suggestion. Just removing a unnecessary additional newline after the "on" section.

.github/workflows/ci.yaml Show resolved Hide resolved
@jedel1043 jedel1043 merged commit 98eff72 into charmed-hpc:main Aug 6, 2024
5 checks passed
@jedel1043 jedel1043 deleted the reintroduce-ci branch August 6, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NucciTheBoss NucciTheBoss NucciTheBoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedel1043 @NucciTheBoss