Fix the resume action in the slurmctld charm #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the command run by the *resume* action. The previous command set the state argument as *resume*, which was leading to the error *slurm_update error: Invalid node state specified*.
|
Hey @matheushent 👋 Thanks for this PR! I'm currently doing some work over on #35 that will simplify how we interface with Slurm. Once we have that landed, I'll get this PR reviewed 😄 |
matheushent
changed the title
NucciTheBoss
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
LGTM 👍
Eventually we'll roll this into the scontrol method we've added to slurm_ops as all calls will be streamed to the juju debug log, but it'll be good to have the resume action good and going 🤩
Here's the scontrol method from slurm_ops: https://github.com/charmed-hpc/hpc-libs/blob/eaa1978d2c51f22e6bffd6a1cea56e54b67534d4/lib/charms/hpc_libs/v0/slurm_ops.py#L901-L908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the resume action in the slurmctld charm. The source error can be seen on this link.
Essentially, the command to resume the nodes has been patched from
scontrol update nodename=<names> state=resumetoscontrol update nodename=<names> state=idle.As I understand Slurm's documentation, there's no operational change applied by this PR.