Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce TiCS analysis to the repo #28

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

jedel1043
Copy link
Collaborator

@jedel1043 jedel1043 commented Oct 1, 2024

This introduces a Github action that uses the TiCS framework to send code quality statistics to TIOBE.

@jedel1043 jedel1043 added the enhancement New feature or request label Oct 1, 2024
@jedel1043
Copy link
Collaborator Author

Riiight, external branches don't have access to the secret. We'll leave it as a nightly run then.

@jedel1043 jedel1043 marked this pull request as ready for review October 1, 2024 22:57
@jedel1043 jedel1043 requested a review from NucciTheBoss October 1, 2024 22:57
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit, but other than that, this looks great! Super helpful to have deeper insight into the code quality of the Slurm charms 🤩

.github/workflows/nightly-TICS.yaml Outdated Show resolved Hide resolved
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for setting this up 🤩

@NucciTheBoss
Copy link
Member

Re-running CI. New action shouldn't affect the integration tests, so probably just an intermittent failure.

@NucciTheBoss NucciTheBoss merged commit 8dd8809 into charmed-hpc:main Oct 2, 2024
5 checks passed
@jedel1043 jedel1043 deleted the tics-analysis branch October 2, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants