Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slurmd,slurmctld): Add common packages to slurmd and slurmctld #24

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

jamesbeedy
Copy link
Contributor

These changes install nfs-common, openmpi-bin, and libpmix-dev to slurmd and nfs-common to slurmctld.

Fixes: #23

@jamesbeedy jamesbeedy changed the title add common packages to slurmd and slurmctld (feat): Add common packages to slurmd and slurmctld Sep 3, 2024
@jamesbeedy jamesbeedy changed the title (feat): Add common packages to slurmd and slurmctld feat: Add common packages to slurmd and slurmctld Sep 3, 2024
@jamesbeedy jamesbeedy changed the title feat: Add common packages to slurmd and slurmctld feat(slurmd,slurmctld): Add common packages to slurmd and slurmctld Sep 3, 2024
These changes install nfs-common, openmpi-bin, and libpmix-dev to
slurmd and nfs-common to slurmctld.

Fixes: charmed-hpc#23
Copy link
Collaborator

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Note for the future: Add tests that use the added common packages to ensure everything works correctly.

@jedel1043 jedel1043 added the enhancement New feature or request label Sep 5, 2024
@jedel1043 jedel1043 merged commit 232d4c0 into charmed-hpc:main Sep 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add common packages to the slurm charms
2 participants