Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slurmctld): correctly parse nested config #19

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jamesbeedy
Copy link
Contributor

These changes modify the user supplied config parser so that it correctly handles nested user supplied configuration values.

Fixes #14

@NucciTheBoss
Copy link
Member

@jamesbeedy is this PR the follow-on to #15?

@jamesbeedy jamesbeedy force-pushed the fix_parsing_nested_config branch 3 times, most recently from 4205560 to 16e4f06 Compare August 20, 2024 20:03
These changes modify the user supplied config parser so that
it correctly handles nested user supplied configuration values.

Accompanying test to show nested configuration is parsed correctly
in test_charm.py

Fixes charmed-hpc#14
@NucciTheBoss NucciTheBoss self-requested a review August 20, 2024 20:33
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks James!

@NucciTheBoss NucciTheBoss merged commit 4ddc566 into charmed-hpc:main Aug 20, 2024
5 checks passed
@jamesbeedy jamesbeedy deleted the fix_parsing_nested_config branch August 20, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom configuration parser blows up when configuration values contain nested key/val pairs
2 participants