-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use composition and inheritance to build service managers #8
Conversation
BREAKING CHANGES: Changes the current API to use composition to enable configuration modification and munge service management. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Decided that these should be defined locally within the Slurm operators themselves rather than bloat the charm library with code that will only be used by a specific operator. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I just have some questions around needing Pyfakefs
.
Signed-off-by: Jason C. Nucciarone <[email protected]>
@jedel1043 good catch with |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Jason C. Nucciarone <[email protected]>
This pull request enhances the API of
slurm_ops
to use composition and inheritance to build the Slurm service operations managers. This makes it easier for us to construct managers aroundslurmctld
,slurmd
,slurmdbd
, andslurmrestd
and share logic for configuration and service management between them.Some use cases
bulk update the configuration of slurmctld:
set a new munge key:
start slurmrestd:
add additional, charm-specific functionality:
Misc.
Adds kebabizer from @jedel1043. The function
format_key(...)
will be used to format Slurm configuration keys before passing off to the Slurm configuration editor.