Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format -> fmt #38

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

NucciTheBoss
Copy link
Member

@NucciTheBoss NucciTheBoss commented Oct 1, 2024

All of the Charmed HPC tox instances use fmt, not format. Switching back to fmt to that devx is consistent across Charmed HPC repos.

Misc. changes:

  • Add periods to the end of each environment description.

Also, this PR highlights that we need to put together a spec for what HPC team tox files should look like. Should make some time at either leading up to roadmap or during the engineering sprint when we have the team together in-person.

All of the Charmed HPC tox instances use `fmt`, not `format`. Switching
back to `fmt` to that devx is consistent across Charmed HPC repos.

Misc. changes:

- Add periods to the end of each environment description.

Signed-off-by: Jason C. Nucciarone <[email protected]>
@NucciTheBoss NucciTheBoss added the enhancement New feature or request label Oct 1, 2024
@NucciTheBoss NucciTheBoss requested a review from jedel1043 October 1, 2024 21:45
Copy link
Contributor

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NucciTheBoss NucciTheBoss merged commit f0d4f73 into charmed-hpc:main Oct 1, 2024
4 checks passed
@NucciTheBoss NucciTheBoss deleted the fix-format-to-fmt branch October 8, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants