feat(slurm_ops): implement initial jwt key manager #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial support for managing jwt keys with the slurm_ops charm library. Currently relies on the cryptography library for generating an RSA key that is used to sign Slurm communications, but we'll eventually be made to rely on a dedicated `jwtctl` tool that can handle the key for us. Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
|
Works on my machine 💀 Edit: Seems to be an issue with Python 3.10 😮💨 |
…path` Signed-off-by: Jason C. Nucciarone <[email protected]>
NucciTheBoss
force-pushed
the
feat-jwt-key
branch
from
c9221fe to
704777d
Compare
jedel1043
reviewed
Oct 1, 2024
…e data directory Signed-off-by: Jason C. Nucciarone <[email protected]>
Follows style recommended in the Google Python styleguide. Signed-off-by: Jason C. Nucciarone <[email protected]>
|
@jedel1043 R4R I created issues to help track the work mentioned in the TODO comments such as switch to the Slurm snap stable channel and creating |
jedel1043
approved these changes
Oct 1, 2024
…tructor Signed-off-by: Jason C. Nucciarone <[email protected]>
|
@jedel1043 one more review to make sure we like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces initial support for managing JWT keys within
slurm_ops. It's similar to the_MungeKeyManagerclass, but with the exception that it uses thecryptographymodule to generate the key rather than a dedicated tool. Ideally we'll eventually use a dedicated tool - something likejwtctl- but that's for next cycle.Also, this PR makes the small change of generating a
StateSaveLocationdirectory for Slurm. The Debian package doesn't do this, so after install the_AptManagerwill create thevar/lib/slurm/slurm.statedirectory that can be used for stashing the key and then exporting across the cluster. There doesn't seem to be an agreed upon standard, so I just chose the dirnameslurm.statesince it's clear that this is the directory where the slurm daemons will save their state. The snap usescheckpointas the name, but we can easily change this.Closes #10