test: add unit tests for slurm_ops
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a bit more explanatory about what the method does.
NucciTheBoss
requested changes
Jul 2, 2024
There was a problem hiding this comment.
Overall, looks great! Just a couple minor comments.
Before we merge, can you also add some coverage for lines 89-92? It's the block for handling if the subprocess invocation in _call fails. Not too difficult to add a side effect for subprocess.check_output(...). I want to have this block covered just so we know that the error is properly bubbled up, and it is nice to have the groundwork laid for testing any advanced error recovery mechanisms we might add. Also, who doesn't love 100% coverage 😜
Let me know if you have any questions!
I can live with it 🤣 |
NucciTheBoss
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of magic on the test file to avoid having to repeat 4 times the exact same test code, but I think we can live with that 😬