Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add SlurmOpsError to slurm_ops #13

Merged
merged 1 commit into from
Jul 10, 2024
Merged

feat: Add SlurmOpsError to slurm_ops #13

merged 1 commit into from
Jul 10, 2024

Conversation

jedel1043
Copy link
Contributor

Fixes #11.

@NucciTheBoss NucciTheBoss self-requested a review July 10, 2024 21:09
NucciTheBoss
NucciTheBoss requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments but overall LGTM 👍

It will be good to have a custom error message that we can handle.

lib/charms/hpc_libs/v0/slurm_ops.py Outdated Show resolved Hide resolved
lib/charms/hpc_libs/v0/slurm_ops.py Outdated Show resolved Hide resolved
lib/charms/hpc_libs/v0/slurm_ops.py Outdated Show resolved Hide resolved
@jedel1043 jedel1043 requested a review from NucciTheBoss July 10, 2024 21:24
@jedel1043
Copy link
Contributor Author

Won't bump the version so that we can bump in #12 instead and avoid publishing two consecutive versions.

NucciTheBoss
NucciTheBoss approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@NucciTheBoss NucciTheBoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 🚢

I'll bump the LIBPATCH version in my pull request after rebase. That way we only need to publish one update to Charmhub.

@NucciTheBoss NucciTheBoss merged commit 1b89c13 into charmed-hpc:main Jul 10, 2024
4 checks passed
@jedel1043 jedel1043 deleted the manager-error branch July 10, 2024 21:31
@jedel1043 jedel1043 mentioned this pull request Dec 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NucciTheBoss NucciTheBoss NucciTheBoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Return library error on slurm_ops instead of propagating CalledProcessError
2 participants
@jedel1043 @NucciTheBoss