-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(term): ansi: implement wrap and wordwrap #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
requested review from
meowgorithm,
muesli,
caarlos0 and
maaslalani
March 14, 2024 03:40
caarlos0
approved these changes
Mar 14, 2024
aymanbagabas
force-pushed
the
term/ansi_wrap
branch
3 times, most recently
from
March 14, 2024 16:47
133d340
to
f4d575c
Compare
This is based on @muesli's awesome [reflow](https://github.com/muesli/reflow) library. It uses the ANSI parser state machine to find escape codes and runes. Since it uses the ANSI parser state machine, it supports OSC, DCS, and other sequences.
aymanbagabas
force-pushed
the
term/ansi_wrap
branch
from
March 15, 2024 00:06
f4d575c
to
435a7f0
Compare
mikelorant
reviewed
Mar 19, 2024
mikelorant
reviewed
Mar 19, 2024
mikelorant
reviewed
Mar 19, 2024
mikelorant
reviewed
Mar 19, 2024
mikelorant
reviewed
Mar 19, 2024
Added some comments, I am fairly intermediate in my Go skills, so take them as observations. I may very well be wrong in my suggestions. |
Thank you @mikelorant for reviewing this one! |
mikelorant
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on @muesli's awesome
reflow library. It uses the ANSI parser state machine to find escape codes and runes. Since it uses the ANSI parser state machine, it supports OSC, DCS, and other sequences.
Related: muesli/reflow#71
Benchmarks running against reflow: