Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --version, completions, manpages #29

Closed
wants to merge 2 commits into from
Closed

feat: add --version, completions, manpages #29

wants to merge 2 commits into from

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 22, 2024 •
edited
Loading

not sure how useful completions are in this case... might not be worth adding them... wdyt?

@caarlos0
feat: add --version, completions, manpages
53aa782 
Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 self-assigned this Nov 22, 2024
@caarlos0 caarlos0 added the enhancement New feature or request label Nov 22, 2024
@coveralls
Copy link

coveralls commented Nov 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11974746931

Details

  • 14 of 20 (70.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 89.616%
Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 14 20 70.0%
Totals Coverage Status
Change from base Build 11974720212: -0.6%
Covered Lines: 630
Relevant Lines: 703
💛 - Coveralls

@meowgorithm
Copy link
Member

Makes sense to me. Good CLI hygiene.

@bashbunni
Copy link
Member

do I need to do anything with the output from sequin man? Also, should this command be included in the help command or is it left out on purpose?

@caarlos0
Copy link
Member Author

do I need to do anything with the output from sequin man?

generally the packager should put it in the right places. If you wanna try it, you can do something like:

sequin man | man -l -

@caarlos0
Copy link
Member Author

that said, I don't think this program would benefit much from having completions and man pages, at least not right now... gonna leave it out for now.

@caarlos0 caarlos0 closed this Nov 25, 2024
@caarlos0 caarlos0 deleted the completions branch November 25, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanbagabas aymanbagabas aymanbagabas approved these changes

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@caarlos0 @coveralls @meowgorithm @bashbunni @aymanbagabas