fix: minor typo in grayscale conversion #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the linter timed out |
|
Re-running… |
|
Thank you for your contribution @CannibalVox! Could you write a test case covering this specific case? |
|
That should do the trick, @aymanbagabas |
aymanbagabas
approved these changes
Nov 21, 2024
meowgorithm
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grayscale conversion takes 0..255 colors for the color indices determined in the first part of the algorithm and averages them and does some other stuff to convert them to a grayscale color.
Unfortunately, the existing code was taking the color indices instead of the 0..255 colors, which was causing the grayscale color to always be black, and rarely be chosen. This fix will improve conversion of grayscale colors.