fix: process nested sequence messages in order #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hrily/bubbletea/examples/nested-sequence is the example to reproduce the bug from the issue and gives the expected output with the fix from this commit: |
| // process nested sequence messages in order | ||
| if sequenceMsg, ok := msg.(sequenceMsg); ok { | ||
| for _, cmd := range sequenceMsg { | ||
| p.Send(cmd()) |
There was a problem hiding this comment.
What if we have deeply nested sequences (3+)? Imagine we have a cmd like:
sequenceMsg: [
sequenceMsg: [
sequenceMsg: [customMsg11, customMsg12],
sequenceMsg: [customMsg21, customMsg22]
]
]
where each Msg represents a cmd and what will be returned after running it.
Doesn't this solution only work for the first two sequences? The outermost sequence is handled by line 363, and then the second sequence is handled here, but the third and fourth sequences (with the customMsg*s) will be done concurrently -- customMsg11 will happen before customMsg12, but customMsg21 could occur before customMsg11, after customMsg11, or after customMsg12. Am I missing something?
aymanbagabas
requested review from
meowgorithm and
aymanbagabas
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #680