Allow disabling 3' Shifting in the rest server #555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@holtgrewe,
I work on @CarlosBorroto 's team, and this PR is continuing the discussion on #551 . I saw that there's a fix(#553) to enable
--no-3-prime-shifting
argument forannotate-pos
command, thanks for fixing it! In our use cases, we use the rest server to annotate variants., so we are hoping to have an option to disable 3' shifting on the rest server as well.We noticed that when running
rest-server
command,--no-3-prime-shifting
is already an optional argument.it's just not actually being hooked up yet. So in this PR, we proposed a change to enable
--no-3-prime-shifting
in the rest server:--no-3-prime-shifting
argument in the Rest Server.To disable shifting variants towards the 3' end of the transcript, run the rest server with
--no-3-prime-shifting
argument.For example,
java -jar jannovar-cli-0.40-SNAPSHOT.jar rest-server -d data/hg19_refseq.ser --no-3-prime-shifting
Additionally, we proposed a new query param that allow a user to disable 3 prime shifting in an api request.
no-3-prime-shifting
as an api query param to temporarily disable 3 prime shifting.For example,
https://{base_url}/annotate-var/refseq/hg19/chrX/108924495/C/CTTA?no-3-prime-shifting
Notice that this query param is only for disabling 3' shifting, so if will only take effect if the rest server is running with 3' shift enabled.
Please let me know your thoughts on the changes or if I miss anything. Thank you!