Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-drupal, starters-*) - Add Next 15 support #824

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

yobottehg
Copy link
Contributor

@yobottehg yobottehg commented Dec 6, 2024

This pull request is for: (mark with an "x")

  • examples/*
  • modules/next
  • packages/next-drupal
  • starters/basic-starter
  • starters/graphql-starter
  • starters/pages-starter
  • Other

GitHub Issue: #811

Describe your changes

  • Added support for Next.js 15 and React 19 stable in next-drupal module
  • Removed support for Next.js 13 and 14 and React 18 because of incompabilities in how async requests are handled.
  • Adjusted all starters to use Next.js 15 and React 19 stable

After reading through https://nextjs.org/docs/app/building-your-application/upgrading/version-15#async-request-apis-breaking-change I decided to not add the "workaround" to also support Next.js 14 because:

  1. Pages router is not affected and can totally easily be upgraded to Next.js 15
  2. App router support for next-drupal is still in beta so we can do these kind of breaking changes.
  3. Documentation says "Temporarily allow ..." Whatever that means! So better be safe.

The Changes for <Link> inside the Pages router starter is because the types did not work anymore with the pages router and react 19. I could not find a workaround. Therefore I just removed the custom "non-prefetch" link as I think this an implementation detail which is not required inside a starter / example.

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-drupal-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:00pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
next-drupal ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 2:00pm
next-drupal-v1-6 ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 2:00pm

Copy link

vercel bot commented Dec 6, 2024

@yobottehg is attempting to deploy a commit to the Chapter Three Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant