Fix compilation of prototypes #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
peterrum
approved these changes
Aug 19, 2024
blaisb
approved these changes
Aug 20, 2024
blaisb
pushed a commit
that referenced
this pull request
Aug 20, 2024
Description Add prototypes compilation to ensure that they are all up to date. Follow up on PR #1249.
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description The prototypes were not compiling due to minor changes on the vtk compression level and interpolation via solution transfer. Solution The calls were updated according to current deal.II documentation. Former-commit-id: ed30045
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description Add prototypes compilation to ensure that they are all up to date. Follow up on PR chaos-polymtl#1249. Former-commit-id: f7e869a
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Description The prototypes were not compiling due to minor changes on the vtk compression level and interpolation via solution transfer. Solution The calls were updated according to current deal.II documentation. Former-commit-id: ed30045
blaisb
pushed a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The prototypes were not compiling due to minor changes on the vtk compression level and interpolation via solution transfer.
Solution
The calls were updated according to current deal.II documentation.
Miscellaneous (will be removed when merged)
We should probably add the prototypes to the CI to ensure compilation. I will do it in a follow PR if @blaisb agrees.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: