Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Homogeneous reactive physics implementation #1242

Closed
wants to merge 12 commits into from

Conversation

oguevremont
Copy link
Collaborator

WIP

Description

There is a growing need to be able to handle reactive systems in Lethe, partly to be able to model chemical reactors. This PR implements a new auxiliary physics able to handle a flexible number of reactive species in homogeneous reactions (for now).

Testing

Documentation

Miscellaneous (will be removed when merged)

Checklist (will be removed when merged)

See this page for more information about the pull request process.

Code related list:

  • All in-code documentation related to this PR is up to date (Doxygen format)
  • Lethe documentation is up to date
  • New feature has unit test(s) (preferred) or application test(s), and restart files are in the generator folder
  • The branch is rebased onto master
  • Changelog (CHANGELOG.md) is up to date
  • Code is indented with indent-all and .prm files (examples and tests) with prm-indent

Pull request related list:

  • Labels are applied
  • There are at least 2 reviewers (or 1 if small feature) excluding the responsible for the merge
  • If this PR closes an issue or is related to a project, it is linked in the "Projects" or "Development" section
  • If the fix is temporary, an issue is opened
  • The PR description is cleaned and ready for merge

@oguevremont oguevremont added the WIP When a PR is open but not ready for review label Aug 15, 2024
@oguevremont oguevremont changed the title Homogeneous reactive physics implementation [WIPHomogeneous reactive physics implementation Aug 15, 2024
@oguevremont oguevremont changed the title [WIPHomogeneous reactive physics implementation [WIP] Homogeneous reactive physics implementation Aug 15, 2024
@oguevremont oguevremont force-pushed the reactive_physics_implementation branch from f08aff5 to a08cbdd Compare September 5, 2024 15:25
@oguevremont oguevremont force-pushed the reactive_physics_implementation branch from 911c227 to 29eaad8 Compare September 10, 2024 15:08
@blaisb blaisb closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP When a PR is open but not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants