Optimize heat transfer #1037
Merged
Optimize heat transfer #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hepap
approved these changes
Feb 20, 2024
Co-authored-by: hepap <[email protected]>
Co-authored-by: hepap <[email protected]>
AmishgaAlphonius
approved these changes
Feb 21, 2024
Co-authored-by: Amishga Alphonius <[email protected]>
Co-authored-by: Amishga Alphonius <[email protected]>
Co-authored-by: Amishga Alphonius <[email protected]>
M-Badri
pushed a commit
to M-Badri/lethe
that referenced
this pull request
Sep 29, 2024
Description of the problem The heat transfer calls a lot of time the calculate_bdf_coefficients and this turns out to be significantly more expensive than I thought it was. Description of the solution we change the calculation of the bdf coefficients to occur only once per time step in the simulation control object and we just query the value. For phase change cases this has a tremendous impact on performance Co-authored-by: hepap <[email protected]> Co-authored-by: Amishga Alphonius <[email protected]> Former-commit-id: b83596d
blaisb
added a commit
that referenced
this pull request
Sep 30, 2024
Description of the problem The heat transfer calls a lot of time the calculate_bdf_coefficients and this turns out to be significantly more expensive than I thought it was. Description of the solution we change the calculation of the bdf coefficients to occur only once per time step in the simulation control object and we just query the value. For phase change cases this has a tremendous impact on performance Co-authored-by: hepap <[email protected]> Co-authored-by: Amishga Alphonius <[email protected]> Former-commit-id: b83596d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem
Description of the solution