JVM: support inject fault to MySQL Java client #106

WangXiangUSTC · 2021-12-01T09:11:08Z

close issue JVM attack support inject fault to MySQL #104
update stress and gc in JVM, use https://github.com/chaos-mesh/byteman-helper

Usage

chaosd attack jvm mysql --help
inject fault into MySQL client

Usage:
  chaosd attack jvm mysql [options] [flags]

Flags:
  -d, --database string               the match database
      --exception string              the exception message needs to throw
  -h, --help                          help for mysql
      --latency int                   the latency duration, unit ms
  -v, --mysql-connector-version int   the version of mysql-connector-java, only support 5.X.X(set to 5) and 8.X.X(set to 8) (default 5)
  -t, --table string                  the match table

Global Flags:
      --log-level string   the log level of chaosd. The value can be 'debug', 'info', 'warn' and 'error'
      --pid int            the pid of Java process which need to attach
      --port int           the port of agent server (default 9288)
      --uid string         the experiment ID

Signed-off-by: xiang <[email protected]>

ti-chi-bot · 2021-12-01T09:11:10Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Andrewmatilde
cwen0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: xiang <[email protected]>

Andrewmatilde

LGTM.

Andrewmatilde · 2022-01-24T04:47:02Z

pkg/server/chaosd/jvm.go

@@ -83,13 +60,25 @@ func (j jvmAttack) Attack(options core.AttackConfig, env Environment) (err error
 		log.Debug(string(output), zap.Error(err))
 	}

+	// submit helper jar
+	bmSubmitCmd := fmt.Sprintf(bmSubmitCommand, attack.Port, "b", fmt.Sprintf("%s/lib/byteman-helper.jar", os.Getenv("BYTEMAN_HOME")))


I think we may add this into docs.

why need to do this, I think it's the internal implementation logic

Andrewmatilde · 2022-01-24T05:00:52Z

PTAL @cwen0

Andrewmatilde · 2022-01-24T05:02:35Z

I think we should add e2e-test for JVM test.

Signed-off-by: xiang <[email protected]>

WangXiangUSTC · 2022-02-08T08:23:40Z

I think we should add e2e-test for JVM test.

You are right, I add a integration test, PTAL again @Andrewmatilde

Andrewmatilde

LGTM

cwen0 · 2022-02-10T11:27:53Z

@WangXiangUSTC We need a new document to guide users on how to use it.

WangXiangUSTC · 2022-02-10T11:30:58Z

@WangXiangUSTC We need a new document to guide users on how to use it.

chaos-mesh/website#245 create an issue for it @cwen0

cwen0 · 2022-02-10T11:54:13Z

@WangXiangUSTC How about split to two pr? You can update stress and gc in JVM by using https://github.com/chaos-mesh/byteman-helper in a single pr.

WangXiangUSTC · 2022-02-11T02:19:21Z

@WangXiangUSTC How about split to two pr? You can update stress and gc in JVM by using https://github.com/chaos-mesh/byteman-helper in a single pr.

OK

Signed-off-by: xiang <[email protected]>

cwen0 · 2022-02-18T02:18:40Z

pkg/core/jvm.go

@@ -123,6 +137,24 @@ type JVMStressSpec struct {
 	MemoryType string `json:"mem-type,omitempty"`
 }

+// only when SQL match the Database, Table, SQLType, chaosd will inject fault


This comment is incomplete and irregular.

It passed the check with the Grammarly 🥲

It is customary for go comments to begin with the "JVMMySQLSpec" and introduce the general information about this strcut.

cwen0 · 2022-02-18T02:59:43Z

pkg/core/jvm.go

+	Table string
+
+	// the match sql type
+	SQLType string


Is this field required? If I want to inject delay on all SQL of a specific table, do this feature supported?

Both Database, Table and SQLType are not required, the default value is "". For example:

select * from test.t1 can match config Database="test", Table='", SQLType=""

select * from test.t1 can match config Database="", Table="t1", SQLType=""

select * from test.t1 can match config Database="test", Table='", SQLType="select"

all sql can match Database="", Table='", SQLType=""

There is a unit test for this https://github.com/chaos-mesh/byteman-helper/blob/main/BytemanHelper/src/test/java/org/chaos_mesh/byteman/helper/SQLParserTest.java

cmd/attack/jvm.go

Signed-off-by: xiang <[email protected]>

WangXiangUSTC · 2022-02-18T06:01:53Z

I updated the comment, PTAL again @cwen0

Signed-off-by: xiang <[email protected]>

cwen0

LGTM

cwen0 · 2022-02-21T02:18:12Z

/merge

ti-chi-bot · 2022-02-21T02:18:14Z

This pull request has been accepted and is ready to merge.

Commit hash: 4a87c28

WangXiangUSTC added 2 commits December 1, 2021 09:07

support inject fault to MySQL Java client

013d26c

Signed-off-by: xiang <[email protected]>

remove useless code

9132fe9

Signed-off-by: xiang <[email protected]>

ti-chi-bot requested review from Andrewmatilde and YangKeao December 1, 2021 09:11

ti-chi-bot added the size/XL label Dec 1, 2021

WangXiangUSTC changed the title ~~JVM: support inject fault to MySQL Java client~~ [WIP]JVM: support inject fault to MySQL Java client Dec 1, 2021

ti-chi-bot added the do-not-merge/work-in-progress label Dec 1, 2021

WangXiangUSTC and others added 4 commits January 6, 2022 10:39

fix unit test

0065356

Signed-off-by: xiang <[email protected]>

Merge branch 'main' into jvm_mysql

c80c03e

minor update

9d99392

Signed-off-by: xiang <[email protected]>

add unit test && minor update

4beb1b0

Signed-off-by: xiang <[email protected]>

WangXiangUSTC changed the title ~~[WIP]JVM: support inject fault to MySQL Java client~~ JVM: support inject fault to MySQL Java client Jan 6, 2022

ti-chi-bot removed the do-not-merge/work-in-progress label Jan 6, 2022

WangXiangUSTC and others added 3 commits January 19, 2022 15:21

Merge branch 'main' into jvm_mysql

9d838b6

update stress and gc

132365e

Signed-off-by: xiang <[email protected]>

submit helper

0caadf9

Signed-off-by: xiang <[email protected]>

ti-chi-bot added size/XXL and removed size/XL labels Jan 19, 2022

update release ci && minor fix

95cc7ef

Signed-off-by: xiang <[email protected]>

Andrewmatilde approved these changes Jan 24, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 label Jan 24, 2022

add integration test && minor fix

f24c884

Signed-off-by: xiang <[email protected]>

WangXiangUSTC force-pushed the jvm_mysql branch from a2686ed to f24c884 Compare February 8, 2022 07:51

add retry

fed3b0b

Signed-off-by: xiang <[email protected]>

Andrewmatilde approved these changes Feb 10, 2022

View reviewed changes

cwen0 added the documentation Improvements or additions to documentation label Feb 10, 2022

cwen0 removed the documentation Improvements or additions to documentation label Feb 10, 2022

WangXiangUSTC mentioned this pull request Feb 11, 2022

JVM: refine with byteman-helper #128

Merged

WangXiangUSTC added the WIP label Feb 11, 2022

resolve conflicts

6f392a1

Signed-off-by: xiang <[email protected]>

ti-chi-bot added size/L and removed size/XXL labels Feb 15, 2022

cwen0 removed the WIP label Feb 16, 2022

cwen0 reviewed Feb 18, 2022

View reviewed changes

cmd/attack/jvm.go Show resolved Hide resolved

update comment && add config validate

d062ffa

Signed-off-by: xiang <[email protected]>

update comment

4a87c28

Signed-off-by: xiang <[email protected]>

cwen0 approved these changes Feb 21, 2022

View reviewed changes

ti-chi-bot added status/LGT2 and removed status/LGT1 labels Feb 21, 2022

ti-chi-bot added the status/can-merge label Feb 21, 2022

ti-chi-bot merged commit 90f7f9b into chaos-mesh:main Feb 21, 2022

STRRL mentioned this pull request Mar 2, 2022

Release v2.2.0 chaos-mesh/chaos-mesh#2608

Closed

51 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JVM: support inject fault to MySQL Java client #106

JVM: support inject fault to MySQL Java client #106

WangXiangUSTC commented Dec 1, 2021 •

edited

Loading

ti-chi-bot commented Dec 1, 2021 •

edited

Loading

Andrewmatilde left a comment

Andrewmatilde Jan 24, 2022

WangXiangUSTC Jan 27, 2022

Andrewmatilde commented Jan 24, 2022

Andrewmatilde commented Jan 24, 2022 •

edited

Loading

WangXiangUSTC commented Feb 8, 2022

Andrewmatilde left a comment

cwen0 commented Feb 10, 2022

WangXiangUSTC commented Feb 10, 2022

cwen0 commented Feb 10, 2022

WangXiangUSTC commented Feb 11, 2022

cwen0 Feb 18, 2022

WangXiangUSTC Feb 18, 2022

cwen0 Feb 18, 2022

WangXiangUSTC Feb 21, 2022

cwen0 Feb 18, 2022

WangXiangUSTC Feb 18, 2022 •

edited

Loading

WangXiangUSTC commented Feb 18, 2022

cwen0 left a comment

cwen0 commented Feb 21, 2022

ti-chi-bot commented Feb 21, 2022

JVM: support inject fault to MySQL Java client #106

JVM: support inject fault to MySQL Java client #106

Conversation

WangXiangUSTC commented Dec 1, 2021 • edited Loading

Usage

ti-chi-bot commented Dec 1, 2021 • edited Loading

Andrewmatilde left a comment

Choose a reason for hiding this comment

Andrewmatilde Jan 24, 2022

Choose a reason for hiding this comment

WangXiangUSTC Jan 27, 2022

Choose a reason for hiding this comment

Andrewmatilde commented Jan 24, 2022

Andrewmatilde commented Jan 24, 2022 • edited Loading

WangXiangUSTC commented Feb 8, 2022

Andrewmatilde left a comment

Choose a reason for hiding this comment

cwen0 commented Feb 10, 2022

WangXiangUSTC commented Feb 10, 2022

cwen0 commented Feb 10, 2022

WangXiangUSTC commented Feb 11, 2022

cwen0 Feb 18, 2022

Choose a reason for hiding this comment

WangXiangUSTC Feb 18, 2022

Choose a reason for hiding this comment

cwen0 Feb 18, 2022

Choose a reason for hiding this comment

WangXiangUSTC Feb 21, 2022

Choose a reason for hiding this comment

cwen0 Feb 18, 2022

Choose a reason for hiding this comment

WangXiangUSTC Feb 18, 2022 • edited Loading

Choose a reason for hiding this comment

WangXiangUSTC commented Feb 18, 2022

cwen0 left a comment

Choose a reason for hiding this comment

cwen0 commented Feb 21, 2022

ti-chi-bot commented Feb 21, 2022

WangXiangUSTC commented Dec 1, 2021 •

edited

Loading

ti-chi-bot commented Dec 1, 2021 •

edited

Loading

Andrewmatilde commented Jan 24, 2022 •

edited

Loading

WangXiangUSTC Feb 18, 2022 •

edited

Loading