-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update statuscake_uptime.py #17
base: master
Are you sure you want to change the base?
Conversation
ContactGroup should be a string, which allows to set multiple contact group IDs (comma separation for multiple ID) according to cf. https://www.statuscake.com/api/Tests/Updating%20Inserting%20and%20Deleting%20Tests.md
Hi @niavlysAO, unfortunately this type change will break the check mode. Check out ansible-statuscake/library/statuscake_uptime.py Lines 385 to 386 in a2472a0
I understand that is something that needs improvement, so thank you for your PR and feel free to contribute! |
Added BasicUser / BasicPass management I didn't get how to modify check mode to manage multiple contact group though. Any clue on how to do that ? |
@niavlysAO In order to get multiple contact groups I think you should modify the convert() function to handle contact groups IDs as a comma-separated string instead a single integer. I suggest you keep For this PR when you finish rebasing it to branch master I can approve and merge the contribution. Sorry for late reply. |
ContactGroup should be a string, which allows to set multiple contact group IDs (comma separation for multiple ID)
according to
cf. https://www.statuscake.com/api/Tests/Updating%20Inserting%20and%20Deleting%20Tests.md
hope it will help