fix: tissue_ontology_term_id and cell_type_ontology_term_id fields for 3 new species #1235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change
there's a few issues here that this PR addresses:
tissue_ontology_term_id
, but only whentissue_type == cell culture
tissue_ontology_term_id
even if species is zebrafish / fruit fly / roundwormcell_type_ontology_term_id
even if species is zebrafish / fruit fly / roundwormthis PR: https://github.com/chanzuckerberg/single-cell-curation/pull/1231/files introduced some issues with these 3 cases weren't being properly handled with moving the logic to the schema def. so i've moved the organism-specific logic back into the validate script directly.
we will revisit an approach to writing out the validation rules here sometime next week.
Testing
Notes for Reviewer