Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support development_stage_ontology_term_id and tissue_type cols based on 5.3 reqs #1234

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

joyceyan
Copy link
Contributor

Changes

  • tissue_type is no longer required to be tissue for zebrafish / fruit fly / roundworm, so i removed that validation entirely
  • development_stage_ontology_term_id has slightly different validation rules for fruit fly and roundworm, so i've updated to account for those changes

Testing

  • updated / added / removed tests as needed

Notes for Reviewer

@joyceyan joyceyan requested a review from ejmolinelli January 31, 2025 00:53
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (9c1f6af) to head (c49aa66).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1234   +/-   ##
=======================================
  Coverage   89.79%   89.79%           
=======================================
  Files          19       19           
  Lines        2147     2147           
=======================================
  Hits         1928     1928           
  Misses        219      219           
Components Coverage Δ
cellxgene_schema_cli 90.73% <ø> (ø)
migration_assistant 91.26% <ø> (ø)
schema_bump_dry_run_genes 79.80% <ø> (ø)
schema_bump_dry_run_ontologies 99.53% <ø> (ø)

@joyceyan joyceyan merged commit 8112a32 into main Jan 31, 2025
14 checks passed
@joyceyan joyceyan deleted the joyce/fix-more-cols branch January 31, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants