Remove redundant check for "active" plugins on npe2api #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aganders3
added
the
bug-fix
manasaV3
reviewed
Jan 14, 2025
|
I'm not sure why the Push Remote Dev workflow is failing. It looks okay to me in Terraform. |
aganders3
changed the title
aganders3
commented
Jan 21, 2025
Comment on lines
-45
to
-50
| if pypi_plugin_version is None and is_plugin_active(name, version): | ||
| logger.info( | ||
| f"Skipping marking plugin={name} version={version} stale as the " | ||
| f"plugin is still active in npe2api" | ||
| ) | ||
| continue |
There was a problem hiding this comment.
This is the main feature of this PR. This should result in removal of the duplicate plugins we were seeing on prod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the check with npe2api for "active" plugins that prevents plugins from being marked stale. The check was made redundant by #1331. This closes #1334, because relevant plugins (those already in Dynamo with matching non-normalized names on npe2api/plugins) will now be marked "stale" and removed from the public view of the hub.