fix: Sample View header & pipeline version #160
Conversation
| @@ -2971,7 +2971,7 @@ type WorkflowRun implements EntityInterface & Node { | |||
| _id: GlobalID! | |||
| cachedResults: String | |||
| collectionId: Int! | |||
| createdAt: DateTime! | |||
There was a problem hiding this comment.
Do you know why my DateTime's are always trying to change? @jfoo1984
There was a problem hiding this comment.
I don't have any idea, but I did some searching and found a couple links that could help, though I don't think they're our exact issue. I'm not sure exactly where this type is coming from, but the timestamps in our sample JSONs are ISO8601 dates, so that's probably why it was changing it to that type? I'm not really sure how to fix this from the links below though.
github-community-projects/graphql-client#17
https://the-guild.dev/graphql/scalars/docs/scalars/date-time
There was a problem hiding this comment.
is there a problem if you use ISO8601DateTime?
There was a problem hiding this comment.
might also be worth checking with The Guild team.
There was a problem hiding this comment.
Yeah I also noticed the snapshot test seems to be changing the types back and forth nondeterministically? (not completely sure though, didn't dig)
Pull Request
JIRA Ticket
no ticket
Description
Make default pipeline id into a string so that it can be matched on the front end.
Notes
This bug was keeping the header buttons from showing on Sample Report.
Tests
Load Sample Report with next gen flag off and see no buttons on pipeline tabs.