fix: add required types to admin samples response (#336)

Co-authored-by: Nina Bernick <[email protected]>
chanzuckerberg · Apr 25, 2024 · 9cbf1cb · 9cbf1cb
1 parent 500a283
commit 9cbf1cb
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 14 deletions.
diff --git a/json-schemas/adminSamplesResponse.json b/json-schemas/adminSamplesResponse.json
@@ -62,7 +62,13 @@
                                                 "namespace": {
                                                     "type": "string"
                                                 }
-                                            }
+                                            },
+                                            "required": [
+                                                "id",
+                                                "protocol",
+                                                "path",
+                                                "namespace"
+                                            ]
                                         },
                                         "r2File": {
                                             "type": "object",
@@ -79,7 +85,13 @@
                                                 "namespace": {
                                                     "type": "string"
                                                 }
-                                            }
+                                            },
+                                            "required": [
+                                                "id",
+                                                "protocol",
+                                                "path",
+                                                "namespace"
+                                            ]
                                         },
                                         "taxon": {
                                             "type": "object",
@@ -107,10 +119,18 @@
                                                         "namespace": {
                                                             "type": "string"
                                                         },
+                                                        "protocol": {
+                                                            "type": "string"
+                                                        },
                                                         "id": {
                                                             "type": "string"
                                                         }
-                                                    }
+                                                    },
+                                                    "required": [
+                                                        "path",
+                                                        "namespace",
+                                                        "id"
+                                                    ]
                                                 }
                                             }
                                         },

diff --git a/sample-responses/adminSamples.json b/sample-responses/adminSamples.json
@@ -35,6 +35,7 @@
             "primerFile": {
               "file": {
                 "path": "samples/1224/33171/fastqs/Primer_K.bed",
+                "protocol": "s3",
                 "namespace": "idseq-samples-staging",
                 "id": "397ae4c0-2c88-525a-8f85-0a00e338adf0"
               }

diff --git a/tests/__snapshots__/UnifiedSchema.test.ts.snap b/tests/__snapshots__/UnifiedSchema.test.ts.snap
@@ -4759,23 +4759,24 @@ type query_adminSamples_items_sequencingReads_edges_items_node_primerFile {
 }
 
 type query_adminSamples_items_sequencingReads_edges_items_node_primerFile_file {
-  id: String
-  namespace: String
-  path: String
+  id: String!
+  namespace: String!
+  path: String!
+  protocol: String
 }
 
 type query_adminSamples_items_sequencingReads_edges_items_node_r1File {
-  id: String
-  namespace: String
-  path: String
-  protocol: String
+  id: String!
+  namespace: String!
+  path: String!
+  protocol: String!
 }
 
 type query_adminSamples_items_sequencingReads_edges_items_node_r2File {
-  id: String
-  namespace: String
-  path: String
-  protocol: String
+  id: String!
+  namespace: String!
+  path: String!
+  protocol: String!
 }
 
 type query_adminSamples_items_sequencingReads_edges_items_node_taxon {