Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI pipeline by GitHub Action #2164

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add CI pipeline by GitHub Action #2164

merged 1 commit into from
Apr 18, 2024

Conversation

yangwooseong
Copy link
Collaborator

@yangwooseong yangwooseong commented Apr 18, 2024 •
edited
Loading

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

  • GitHub Action 기반의 CI 워크플로우를 추가합니다.
  • 워크플로우에서 secrets.TURBO_SERVER_TOKEN 를 사용하고 있기 때문에 이 pr이 머지되기 전에 레포지토리 시크릿으로 설정해야 합니다. Settings > Secrets and Variables > Actions > Repository Secrets 에서 설정 가능합니다. 값은 아무거나 해도 되기 때문에 적당한 해시값으로 하면 될 것 같습니다. 제가 권한이 없어서 설정 부탁드립니다 @sungik-choi
  • pr 이 머지되고 ci가 잘 도는 것을 확인하면 Circle CI 설정 파일(config.yml)을 제거하면 될 것 같습니다.

Details

  • Reduce time to perform CI tasks (Restore cache behavior) #1684 에서 제안한 것처럼 build, lint, typecheck, test 를 하나의 job 안에서 실행합니다.
  • 깃헙 artifact 를 리모트 캐시로 저장하는 action 을 사용하여 리모트 캐시를 활성화합니다.
  • 현재 4분정도 걸리는 시간이 풀 터보일 때는 1분으로, bezier-react패키지만 변경될 때는 2분으로 줄어들었습니다. 그리고 수정하지 않은 패키지들은 캐시 힛이 되기 때문에, bezier-tokens같은 패키지를 수정하면 1분 20초정도 시간밖에 안걸리게 됩니다.

Breaking change? (Yes/No)

  • No

References

@yangwooseong yangwooseong added enhancement Issues or PR related to making existing features better ci Issue or PR related to continuous integration labels Apr 18, 2024
@yangwooseong yangwooseong self-assigned this Apr 18, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 82cc155

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@channel-io channel-io deleted a comment from channeltalk bot Apr 18, 2024
@yangwooseong yangwooseong changed the title Adopt GitHub Action for CI Add CI pipeline by GitHub Action Apr 18, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.62%. Comparing base (a1885d8) to head (82cc155).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2164   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files         126      126           
  Lines        2655     2655           
  Branches      777      786    +9     
=======================================
  Hits         2300     2300           
+ Misses        350      326   -24     
- Partials        5       29   +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sungik-choi
sungik-choi approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@sungik-choi sungik-choi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 PR 푸시마다 실행하는 거 감안하면 정말 많이 줄어들었네요
이 PR과 별도로 마지막 Step에 prettier format(yarn format)도 추가할지 고민중입니다..!

.github/workflows/ci.yml
runs-on: ubuntu-latest
env:
TURBO_API: http://127.0.0.1:9080
TURBO_TOKEN: ${{ secrets.TURBO_SERVER_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TURBO_SERVER_TOKEN 토큰 설정해뒀습니다!

@channel-io channel-io deleted a comment from channeltalk bot Apr 18, 2024
@yangwooseong
Copy link
Collaborator Author

👍 PR 푸시마다 실행하는 거 감안하면 정말 많이 줄어들었네요 이 PR과 별도로 마지막 Step에 prettier format(yarn format)도 추가할지 고민중입니다..!

로컬에서 실행해보니 5~6초 걸리는 것 같아서 넣어도 괜찮아 보입니다! 옵션만 --write 대신 --check로 주면 될듯 합니다

@channeltalk ChannelTalk
Copy link

channeltalk bot commented Apr 18, 2024

https://desk.channel.io/#/channels/1/team_chats/groups/1237/6620d4e003fc558fe52e

@yangwooseong yangwooseong merged commit 5359c2c into channel-io:main Apr 18, 2024
9 checks passed
@yangwooseong yangwooseong deleted the web-223 branch April 18, 2024 08:10
@yangwooseong yangwooseong mentioned this pull request Apr 23, 2024
Merged
6 tasks
yangwooseong added a commit that referenced this pull request Apr 23, 2024
@yangwooseong
codecov test PR (#2171)
bb54b99 
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Related Issue

<!-- Please link to issue if one exists -->

- #2164 

<!-- Fixes #0000 -->

## Summary

<!-- Please brief explanation of the changes made -->

- Codecov 리포트를 테스트하기 위한 pr 입니다. 


## Details

<!-- Please elaborate description of the changes -->

### Breaking change? (Yes/No)

<!-- If Yes, please describe the impact and migration path for users -->

## References

<!-- Please list any other resources or points the reviewer should be
aware of -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungik-choi sungik-choi sungik-choi approved these changes

Assignees

@yangwooseong yangwooseong

Labels
ci Issue or PR related to continuous integration enhancement Issues or PR related to making existing features better
Projects
No open projects
Bezier React
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use GitHub action for CI instead of CircleCI Reduce time to perform CI tasks (Restore cache behavior)
2 participants
@yangwooseong @sungik-choi